PR for landing page #17978

anjana-bl · 2023-10-13T15:59:22Z

No description provided.

cla-assistant · 2023-10-14T15:42:00Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ anjana-bl
❌ Jayashree

Jayashree seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

projects/storefrontstyles/scss/components/content/navigation/_myaccount-v2-navigation.scss

feature-libs/user/account/assets/translations/en/user-account.ts

feature-libs/user/account/components/myaccount-v2-user/myaccount-v2-user.component.ts

feature-libs/order/assets/translations/en/order.i18n.ts

feature-libs/customer-ticketing/assets/translations/en/customer-ticketing.ts

feature-libs/order/assets/translations/en/order.i18n.ts

...cms-components/myaccount/my-account-v2-navigation/my-account-v2-navigation.component.spec.ts

projects/storefrontstyles/scss/components/content/navigation/_my-account-v2-navigation.scss

projects/schematics/src/shared/constants.ts

projects/schematics/src/add-spartacus/spartacus-features.ts

projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts

feature-libs/order/styles/components/my-account-v2/_my-account-v2-order.scss

feature-libs/order/assets/translations/translations.ts

Platonn · 2023-10-17T10:36:05Z

feature-libs/order/assets/translations/en/my-account-v2-order.i18n.ts

+    viewAllOrders: 'View All Orders',
+    noInvoices: 'Invoices are not generated yet. Please come back later.',
+  },
+  myAccountView: {


[MEDIUM]
It seems that somehow the previous comment suggesting to use here myAccountViewOrder instead of myAccountView wasn't covered. Maybe the latest changes were not pushed?

…o MyAccount-PR-2

Platonn · 2023-10-17T12:23:51Z

feature-libs/order/assets/translations/en/my-account-v2-order.i18n.ts

+    viewAllOrders: 'View All Orders',
+    noInvoices: 'Invoices are not generated yet. Please come back later.',
+  },
+  myAccountViewOrder: {


[QUESTION]
Only now I noticed that this translation key namespace doesn't have myAccountV2 in it's prefix.

Other namespaces have it:
myAccountV2ConsignmentTracking
myAccountV2OrderHistory
myAccountV2OrderDetails

What do you think about having here myAccountV2ViewOrder for consistency?
Thanks to this consistency, other devs (or even teams) taking this PR as a representative example to copy and follow, they will have no confusion about "when to add the prefix and when not". The answer should be: for everything that is related to the new my account, let's add the prefix "my account v2"

done, changed the name to myAccountV2Orders

cypress · 2023-10-17T13:03:58Z

4 flaky tests on run #41667 ↗︎

0	119	2	0	4

Details:

Merge `bd6447e` into `bda9b73`...
Project: spartacus	Commit: `5db99c1be1 ℹ️`
Status: Passed	Duration: 07:45 💡
Started: Oct 17, 2023 12:56 PM	Ended: Oct 17, 2023 1:03 PM

regression/checkout/checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
Checkout flow > Mobile > should checkout with a registered user		`Test Replay` `Output` `Screenshots` `Video`

ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test		Artifacts
SSR > should render homepage		`Test Replay` `Output` `Screenshots` `Video`
SSR > should render PLP		`Test Replay` `Output` `Screenshots` `Video`
SSR > should render PDP		`Test Replay` `Output` `Screenshots` `Video`

Review all test suite changes for PR #17978 ↗︎

anjana-bl added 7 commits October 13, 2023 11:32

new changes

73a4fb6

removing guard - as per review

8b0ddee

naming change

3abd427

Update .env-cmdrc

f89fd98

Update public_api.ts

316b7d0

order history + customer ticket

2544f0e

review comments

bdfa4d0

anjana-bl requested a review from a team as a code owner October 13, 2023 15:59

anjana-bl marked this pull request as draft October 13, 2023 15:59

landing page: user & navigation

b88cc9e

Jayashree and others added 9 commits October 14, 2023 21:21

linting update

a96a2db

unit test case

893d114

unti test

19ca801

unit test - order + customer ticketing

6f140b5

Merge branch 'MyAccount-PR-1' into MyAccount-PR-2

3e32355

added myaccount-v2-user.component.spec.ts

44f49fd

Update _myaccount-v2-navigation.scss

b94f330

Create myaccount-v2-navigation.component.spec.ts

d326e00

linting + code coverage

621cef1

Platonn reviewed Oct 16, 2023

View reviewed changes

projects/storefrontstyles/scss/components/content/navigation/_myaccount-v2-navigation.scss Outdated Show resolved Hide resolved

Platonn reviewed Oct 16, 2023

View reviewed changes

feature-libs/user/account/assets/translations/en/user-account.ts Outdated Show resolved Hide resolved

Platonn reviewed Oct 16, 2023

View reviewed changes

feature-libs/user/account/components/myaccount-v2-user/myaccount-v2-user.component.ts Outdated Show resolved Hide resolved

Platonn reviewed Oct 16, 2023

View reviewed changes

feature-libs/order/assets/translations/en/order.i18n.ts Outdated Show resolved Hide resolved

feature-libs/customer-ticketing/assets/translations/en/customer-ticketing.ts Outdated Show resolved Hide resolved

Update _myaccount-v2-navigation.scss

d687733

Platonn reviewed Oct 16, 2023

View reviewed changes

feature-libs/order/assets/translations/en/order.i18n.ts Outdated Show resolved Hide resolved

Jayashree and others added 4 commits October 16, 2023 15:32

review comment for user

7a027b2

unit test case+formatting

221bf3c

renamed myaccount to my-account

7bb99d9

naming change + review comments

0e7d361

Platonn reviewed Oct 17, 2023

View reviewed changes

...cms-components/myaccount/my-account-v2-navigation/my-account-v2-navigation.component.spec.ts Outdated Show resolved Hide resolved

Update my-account-v2-navigation.component.spec.ts

5a1b822

Platonn reviewed Oct 17, 2023

View reviewed changes

projects/storefrontstyles/scss/components/content/navigation/_my-account-v2-navigation.scss Outdated Show resolved Hide resolved

Platonn reviewed Oct 17, 2023

View reviewed changes

projects/schematics/src/shared/constants.ts Outdated Show resolved Hide resolved

projects/schematics/src/add-spartacus/spartacus-features.ts Outdated Show resolved Hide resolved

projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts Outdated Show resolved Hide resolved

Platonn reviewed Oct 17, 2023

View reviewed changes

feature-libs/order/styles/components/my-account-v2/_my-account-v2-order.scss Outdated Show resolved Hide resolved

Platonn reviewed Oct 17, 2023

View reviewed changes

feature-libs/order/assets/translations/translations.ts Outdated Show resolved Hide resolved

Jayashree added 2 commits October 17, 2023 16:03

Update _my-account-v2-navigation.scss

d55b139

Update spartacus-features.module.ts

8db2689

Platonn reviewed Oct 17, 2023

View reviewed changes

Jayashree and others added 8 commits October 17, 2023 16:08

Update constants.ts

2b2a0a4

linting update

187a998

code review changes

74e45a4

Update _my-account-v2-navigation.scss

0607f6c

Merge branch 'MyAccount-PR-2' of https://github.com/SAP/spartacus int…

18a4604

…o MyAccount-PR-2

CXINT-2317: Fixed review comments (#17985)

78f005e

review comment

8235882

Add license header

9b0e5db

An error occurred while trying to automatically change base from MyAccount-PR-1 to develop-6.6.x October 17, 2023 12:13

Merge branch 'MyAccount-PR-1' into MyAccount-PR-2

ad3d497

anjana-bl changed the base branch from MyAccount-PR-1 to develop-6.6.x October 17, 2023 12:19

Platonn reviewed Oct 17, 2023

View reviewed changes

anjana-bl added 2 commits October 17, 2023 17:58

Merge branch 'develop-6.6.x' into MyAccount-PR-2

5a0116a

review change

bd6447e

anjana-bl marked this pull request as ready for review October 17, 2023 12:41

anjana-bl requested a review from a team as a code owner October 17, 2023 12:41

Platonn approved these changes Oct 17, 2023

View reviewed changes

anjana-bl merged commit fe78d73 into develop-6.6.x Oct 17, 2023
22 checks passed

anjana-bl deleted the MyAccount-PR-2 branch October 17, 2023 13:54

Platonn mentioned this pull request Oct 24, 2023

PR - Landing Page to 6.6 #17982

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR for landing page #17978

PR for landing page #17978

anjana-bl commented Oct 13, 2023

cla-assistant bot commented Oct 14, 2023

Platonn Oct 17, 2023 •

edited

Loading

anjana-bl Oct 17, 2023

Platonn Oct 17, 2023 •

edited

Loading

anjana-bl Oct 17, 2023

cypress bot commented Oct 17, 2023

PR for landing page #17978

PR for landing page #17978

Conversation

anjana-bl commented Oct 13, 2023

cla-assistant bot commented Oct 14, 2023

Platonn Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

anjana-bl Oct 17, 2023

Choose a reason for hiding this comment

Platonn Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

anjana-bl Oct 17, 2023

Choose a reason for hiding this comment

cypress bot commented Oct 17, 2023

4 flaky tests on run #41667 ↗︎

Review all test suite changes for PR #17978 ↗︎

Platonn Oct 17, 2023 •

edited

Loading

Platonn Oct 17, 2023 •

edited

Loading